Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(react): Add React Router v7 docs #11990

Merged
merged 3 commits into from
Dec 2, 2024
Merged

docs(react): Add React Router v7 docs #11990

merged 3 commits into from
Dec 2, 2024

Conversation

chargome
Copy link
Member

@chargome chargome commented Nov 28, 2024 •
edited
Loading

This adds documentation for RR7 and also declutters the docs for RR in general by splitting up the versions into different files.

documents getsentry/sentry-javascript#14518

@chargome chargome self-assigned this Nov 28, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 9:22am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:22am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:22am

@chargome chargome requested a review from lforst November 28, 2024 15:35
@chargome chargome mentioned this pull request Nov 28, 2024
Closed
2 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 993 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.13MB 999 bytes (0.01%) ⬆️
sentry-docs-client-array-push 9.02MB 6 bytes (-0.0%) ⬇️

@lforst
Copy link
Member

lforst commented Nov 29, 2024 •
edited
Loading

I would try and make it a bit more obvious that you can toggle the code snippets for v6 and v7. Maybe write out "version" in full or add a not or something.

@lforst
Copy link
Member

lforst commented Nov 29, 2024

Or maybe even a completely separate page for v7 where we outline that the framework mode is not yet supported.

@chargome
Copy link
Member Author

Yeah I tried with a different page at first but imo it makes no sense since the content is basically identical. I'll update the codetabs and add an alert that we do not yet support rr7 framework

@lforst
Copy link
Member

lforst commented Nov 29, 2024

Yeah I tried with a different page at first but imo it makes no sense since the content is basically identical. I'll update the codetabs and add an alert that we do not yet support rr7 framework

It generally doesn't matter if content is identical. People see the version they use, click on it, and will never notice that v6 and v7 are the same. If anything it takes away complexity when reading the docs.

@lforst lforst merged commit 29191c6 into master Dec 2, 2024
11 checks passed
@lforst lforst deleted the cg/rr7-spa branch December 2, 2024 14:47
aliu39 pushed a commit that referenced this pull request Dec 2, 2024
@chargome @aliu39
docs(react): Add React Router v7 docs (#11990)
9feb094
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lforst lforst lforst approved these changes

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chargome @lforst